Skip to content

PositionManager (Uniswap V4 Periphery)

Audit Snapshot

  • Status: ✅ pass
  • Source type: npm
  • Source path: third_party/famous-contracts/sources/@uniswap/v4-periphery/src/PositionManager.sol
  • Primary issue: No primary issue recorded.
  • Audit corpus size: 98 contracts

Diagnostics

Total diagnostics captured: 6392

By Severity

SeverityCount
warning6389
error3

Most Common Codes

CodeCountExample
W2004738function 'revertWith' in 'EIP712_v4' overrides 'ERC721::revertWith' which is not marked 'virtual'
W1211557duplicate constant state variable 'ZERO_DELTA' detected while merging libraries
W11123function 'revokeNonce' is marked payable, but Neo N3 has no native coin transfer; the modifier is accepted for compatibility but has no effect. Use onNEP17Payment(address, uint256, bytes) to handle incoming NEP-17 token payments.
W11621function 'revokeNonce' has payable modifier which has no effect on Neo N3. Use onNEP17Payment callback to receive token payments.
INVALID_STORAGE_RETURN16function 'get' return value 'State' uses 'storage' data location (treated as Any)
MANIFEST_WILDCARD_CONTRACT16contract 'ERC721' requires wildcard contract manifest permissions (contract='*') due to dynamic contract calls. This is riskier than fixed contract hashes; use --deny-wildcard-contracts to make this a hard error.
VALIDATION_WARNING7abstract contract 'ERC721' has 1 unimplemented function(s): [tokenURI]
RAW3[info][NEP-11] NEP-11 Transfer event has 3 parameter(s), expected 4.
W1043function 'transferFrom' with 3 parameters (ERC-721 pattern) detected. NEP-11 uses transfer(to, tokenId, data) with 3 parameters instead. Authorization is via Runtime.checkWitness(owner), not msg.sender.
W1063function 'supportsInterface' (EIP-165) is unnecessary on Neo N3. Neo uses the manifest 'supportedstandards' array for interface detection, which the compiler populates automatically.
W1143NFT contract (has ownerOf) but missing onNEP11Payment callback. Other contracts cannot send NFTs to this contract.
RETURN_TYPE_UNMAPPED2function 'positionInfo' returns 'Any', which may not map cleanly to Neo manifest types

Source diagnostic payload: docs/data/famous-contracts-audit-results.json.

References

MIT Licensed